Skip to content

Incognito mode for large rooms used for announcements#6990

Open
toshanmugaraj wants to merge 4 commits intoelement-hq:developfrom
toshanmugaraj:Incognito
Open

Incognito mode for large rooms used for announcements#6990
toshanmugaraj wants to merge 4 commits intoelement-hq:developfrom
toshanmugaraj:Incognito

Conversation

@toshanmugaraj
Copy link
Contributor

@toshanmugaraj toshanmugaraj commented Oct 27, 2022

This changes related to #6989

Pull Request Checklist

  • [x ] I read the contributing guide
  • [x ] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [ x] Accessibility has been taken into account.
  • [ x] Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • [ x] You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off
    Signed-off-by: Shunmugaraj S toshanmugaraj@gmail.com
    Settings:

Settings

Enabled Mode:

CropedHidden

Disabled Mode:

CropedVisible

…o.enabled.

Filter the events from displaying.
Added settings for room admin to enable the incognito mode.
@toshanmugaraj toshanmugaraj changed the title Incognito mode for large rooms used for announcements #6989 Incognito mode for large rooms used for announcements Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

❌ Patch coverage is 11.23596% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.73%. Comparing base (17b45aa) to head (0c34c9b).
⚠️ Report is 2093 commits behind head on develop.

Files with missing lines Patch % Lines
...Modules/Room/Settings/RoomSettingsViewController.m 0.00% 52 Missing ⚠️
...les/MatrixKit/Models/Room/MXKRoomBubbleComponent.m 5.88% 15 Missing and 1 partial ⚠️
...ules/Room/Members/RoomParticipantsViewController.m 0.00% 8 Missing ⚠️
Riot/Categories/MXRoom+Riot.m 81.81% 2 Missing ⚠️
Riot/Modules/Room/DataSources/RoomDataSource.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6990   +/-   ##
========================================
  Coverage    11.73%   11.73%           
========================================
  Files         1620     1620           
  Lines       159271   159348   +77     
  Branches     64804    64839   +35     
========================================
+ Hits         18687    18702   +15     
- Misses      139940   140009   +69     
+ Partials       644      637    -7     
Flag Coverage Δ
uitests 54.78% <ø> (-0.02%) ⬇️
unittests 5.95% <11.23%> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants