Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications docs #5988

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

dkrasner
Copy link

@dkrasner dkrasner commented Apr 5, 2022

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

Main points

This PR adds a CONFIGURATION.md file and instructions/notes on setting up push notifications (APNs) for the app. It closes #5735

dkrasner and others added 2 commits April 5, 2022 09:48
@pixlwave
Copy link
Member

Hey @dkrasner, thank you so much for taking the time to add this documentation 🙌 Looks great to me.

I've added a couple of comments/suggestions inline. Let me know what you think and then we'll get this merged 👍

@pixlwave
Copy link
Member

pixlwave commented Apr 27, 2022

Oh, and for the PR to be merged please could you add

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push notification issues and documentation
3 participants