Add NSUserActivity to rooms to appear in spotlight search

[kloenk]

This also allows shortcuts to open the app directly opening a room.

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Pull request is based on the develop branch
• Pull request contains a changelog file in ./changelog.d
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[pixlwave]

Thanks for this contribution Finn. I've added a few inline comments.

Would you be able to add a changelog file in ./changelog.d and a sign off for us too please?

[pixlwave]

For this initial implementation, would you mind removing the CSSearchableItemAttributeSet and CSSearchableItem parts and relying on the userActivity.isEligibleForSearch = true for spotlight support? I believe the only visible change this would have is the lack of a subtitle - which may be a positive thing as it could be confusing in the Shortcuts app.

It would be interesting to have spotlight functionality in its own service eventually, so that updates to the index can happen automatically. Then the UserActivityService could request the appropriate attributes to attach to the activity from that service.

[kloenk]

Let's anchor 3086234 here, so it's easier to find how to add it back later on

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}