Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote wakeQueueIfEventsPending and thumbnailer log lines to debug #3520

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

neilalexander
Copy link
Contributor

@neilalexander neilalexander commented Jan 28, 2025

This just produces a lot of noise in the logs for no reason and they didn't even say which queues or thumbnails were relevant.

Signed-off-by: Neil Alexander [email protected]

This just produces a lot of noise in the logs for no reason and it didn't
even say which queue was relevant.

Signed-off-by: Neil Alexander <[email protected]>
@neilalexander neilalexander requested a review from a team as a code owner January 28, 2025 10:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.44%. Comparing base (1b8b88c) to head (b412355).

Files with missing lines Patch % Lines
mediaapi/thumbnailer/thumbnailer.go 0.00% 3 Missing ⚠️
mediaapi/thumbnailer/thumbnailer_nfnt.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3520      +/-   ##
==========================================
+ Coverage   49.36%   49.44%   +0.07%     
==========================================
  Files         524      524              
  Lines       59814    59814              
==========================================
+ Hits        29530    29573      +43     
+ Misses      26794    26759      -35     
+ Partials     3490     3482       -8     
Flag Coverage Δ
unittests 49.44% <20.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neilalexander neilalexander changed the title Demote wakeQueueIfEventsPending log line to debug Demote wakeQueueIfEventsPending and thumbnailer log lines to debug Jan 28, 2025
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Those could be quite noisy, indeed.

@S7evinK S7evinK merged commit 57bbba3 into element-hq:main Jan 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants