-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move semantic dosn't work with eastl::list #523
Comments
Thanks for bringing this up and sharing the related issue. In our internal version of EASTL I recently added tests for allocator propagation because we don't have documentation on the allocator propagation behaviour (see propagate_on_X types from AllocatorAwareContainer). EASTL doesn't have the allocator traits class and instead has the same propagation behaviour for all allocators. The results of my testing were:
Of note, and directly related to your issue is that both list and slist (forward_list) have inconsistent propagation behaviour to the rest of EASTL. Additionally, basic_string also has inconsistent behaviour. Before I can submit a fix I need to do some testing to make sure that EA code is not relying on the current incorrect behaviour for those types. It may be some time before I get to that work. |
For reference / visibility the reproducible example, causing compilation error, is:
Same for slist. |
There is a move semantic problem at the
eastl::list
, which is the as issue as it was with theeastl::vector
:Cannot move assign a eastl::vector<unique_ptr> #56
The solution works, but in case of different allocators an error message would be preferable.
The text was updated successfully, but these errors were encountered: