fix: BrowserWindow.center() should center relative to screen

[codebytere]

Description of Change

Closes #41956.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4916277

The above CL changed window.center() behavior on Windows/Linux (which use Widget) such that the window is now centered relative to the parent window and not the full screen as is the expected behavior and the behavior on macOS. Chromium perceived this a bug, but it's important we maintain our end-user behavior consistency here as it's been this way for the lifetime of the method.

Tested with https://gist.github.com/yangannyx/277e71dc348b289cde39e94b4b59d683

cc @yangannyx

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where calling window.center() on Windows and Linux incorrectly centered the window.

[VerteDinde]

I think the Windows tests may be legitimately failing on sizing BrowserWindow.center() centers the window, unfortunately

[codebytere]

@VerteDinde yeah - i think this might be the reason we didn't have tests already :( it passes on each platform locally, but acts really weird in CI. Might need to just forego the test i think

[nornagon]

Not gonna block this but I feel kinda mixed about this. I sort of agree with Chromium that it could be considered a bug that the parent was ignored, and it does kinda make sense for it to work that way. It's unclear to me what the use case is for wanting to center a child window in the screen as opposed to the parent. And it's nice to just back directly onto the Widget API.

On the other hand, it is a real behavior change that we didn't intend, and the code to revert the behavior isn't that long. If you decide to go ahead with merging this, perhaps put a comment here that explains why we're not using the Widget API?

[codebytere]

@nornagon done!

[release-clerk]

Release Notes Persisted

Fixed an issue where calling window.center() on Windows and Linux incorrectly centered the window.

[trop]

I have automatically backported this PR to "30-x-y", please check out #42100

[trop]

I have automatically backported this PR to "31-x-y", please check out #42101