Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More resilient publish workflow options #3313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jessedp
Copy link
Contributor

@jessedp jessedp commented Sep 9, 2022

This solves two challenges I faced when upgrading the publish workflow:

  1. Without the signing environment vars setup in GH, the build breaks
    • I didn't test this, but I imagine defining them with incorrect values is also unhelpful
  2. Building a "msi", "rpm", or "deb" under only MacOs caused build problems. Running each build on the native OS has so far allowed those to work.

This setup (with some other stuff) is running/working over here.

@amilajack
Copy link
Member

Thanks for this :)

A few questions:

Building a "msi", "rpm", or "deb" under only MacOs caused build problems.

what build problems did you run into?

@jessedp
Copy link
Contributor Author

jessedp commented Sep 21, 2022

It's possible that I was fighting publishing timeout problems.

Not sure if you can see the logs, but these are the runs from the branch I was testing on (DEBUG=electron-builder* is set).

If you can, here's one example that's not just a publish timeout.

I guess one additional benefit is that this also enables more parallel/"faster" builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants