Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented BuildHasher for WyHash #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucaCappelletti94
Copy link
Contributor

@LucaCappelletti94 LucaCappelletti94 commented Aug 21, 2024

As per the title, added a new struct which implements the BuildHasher trait and relative test suite.

Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your proposal.
However, I do not understand the benefit of these methods.
IIUC, the structs can already be created with the methods default(), with_seed() and new(). Which offer the same possibilities.

@LucaCappelletti94
Copy link
Contributor Author

Indeed, but there are crates down the dependency line that require a BuildHasher object other than the Hasher object itself. I agree that there should be only a need for the Hasher in these cases, but these crates chose to require the BuildHasher trait. If you prefer, I could wrap it under a feature flag.

@LucaCappelletti94 LucaCappelletti94 changed the title Implemented HasherBuilder for WyHash Implemented BuildHasher for WyHash Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants