Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier and format files #143

Closed
wants to merge 4 commits into from
Closed

Add Prettier and format files #143

wants to merge 4 commits into from

Conversation

uncenter
Copy link
Contributor

@uncenter uncenter commented Nov 27, 2023

I was working on some other changes on the codebase and noticed the lack of a formatter. I personally Prettier incredibly useful but I understand if this isn't something you are interested in. I've tried to minimize the changes as much as possible by matching the rules to what you have already.

@uncenter
Copy link
Contributor Author

It looks like HTML and CSS were formatted with two space indentation. Would you rather all files have the same indentation now or just keep it like it was before?

@elchininet
Copy link
Owner

Hi @uncenter,
Thanks for contributing. It is good to search first to see if something was already proposed related to that. I am OK with any new Eslint rules, but please, remove Prettier from this pull request, and do not format SVG or anything in the docs dist folder.
Regards

@uncenter
Copy link
Contributor Author

uncenter commented Nov 27, 2023

Oops, didn't check. What do you have against Prettier specifically?

@uncenter uncenter closed this Nov 27, 2023
@elchininet
Copy link
Owner

Oops, didn't check. What do you have against Prettier specifically?

Basically that I don‘t like the things the it does to the style that I have written on purpose in some way. Just create Eslint rules specifically for the things that you want to address.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants