Doc: Provide accurate post-geoip lookup example #18092
Merged
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @karenzone? 🙏
|
🔍 Preview links for changed docs |
|
@kaisecheng, a user pointed out that the "after" example is the same as the "before" example. Will you help me come up with a proper example, please? |
karenzone
added
backport-9.0
|
@karenzone Thx. I updated the example and push to the branch. |
karenzone
commented
Sep 3, 2025
There was a problem hiding this comment.
Renders as expected, and looks great!
Thank you, @kaisecheng.
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Co-authored-by: Kaise Cheng <[email protected]> (cherry picked from commit 23d06e6)
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Co-authored-by: Kaise Cheng <[email protected]> (cherry picked from commit 23d06e6)
This was referenced Sep 3, 2025
karenzone
added a commit
that referenced
this pull request
Sep 3, 2025
(cherry picked from commit 23d06e6) Co-authored-by: Karen Metts <[email protected]> Co-authored-by: Kaise Cheng <[email protected]>
karenzone
added a commit
that referenced
this pull request
Sep 3, 2025
(cherry picked from commit 23d06e6) Co-authored-by: Karen Metts <[email protected]> Co-authored-by: Kaise Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: elastic/docs-content#2782