Replace buildkite jdk version check w/GH action #17945
Conversation
Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action.
donoghuc
added
the
backport-active-all
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
💚 Build Succeeded
|
| git push origin $BRANCH | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.verify-changed-files.outputs.changed == 'true' |
There was a problem hiding this comment.
Have you considered an updatecli workflow for this instead? See an example from beats in https://github.com/elastic/beats/tree/1df4889c66c43c71b7a795f7c735eeb79c48c569/.github/workflows/updatecli.d
There was a problem hiding this comment.
I had not heard of that tool before. That looks very helpful! I pinged you in slack to clarify your suggestion for doing testing for worfklows. Once i have that down i can experiment a bit with using updatecli. Thanks!
There was a problem hiding this comment.
Thanks @dliappis again for the review and suggestions. I opened a PR to add a stub action to test against #17993 and started exploring the updatecli tool with #18035
If you have a chance to look at those that would be great. I was thinking we can get the stub action merged which will inform this and the other proposed action.
There was a problem hiding this comment.
LGTM for the stub, thanks!
Release notes
[rn:skip]
What does this PR do?
Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the
versions.ymlfile in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action.Why is it important/What is the impact to the user?
No user impact, quality of life improvement for logstash devs.
Checklist
How to test this PR locally
Downgrade java version in
versions.ymland run./gradlew updateJdkVersionto update it back to latest.Related issues