Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Introduce snmp-integration for Technical Preview #1648

Merged
merged 5 commits into from
May 13, 2024

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented May 6, 2024

Related: elastic/logstash#16145

We'll need to tweak content and messaging for each branch for expectations and accuracy.

PREVIEW: https://logstash-docs_bk_1648.docs-preview.app.elstc.co/guide/en/logstash/master/plugins-integrations-snmp.html

@karenzone karenzone self-assigned this May 6, 2024
@karenzone
Copy link
Contributor Author

Proposal outlined in the issue:
elastic/logstash#16145 (comment)

@karenzone karenzone requested a review from jsvd May 7, 2024 22:37
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
docs/plugins/integrations/snmp.asciidoc Outdated Show resolved Hide resolved
@karenzone
Copy link
Contributor Author

karenzone commented May 10, 2024

@jsvd, love the changes! Thank you for investing. I need a 👍 so that I can merge this and move on to the next steps.

Next up:

In the interim, I'll keep a close eye on the generated docs PRs to be sure that we're not accidentally overwriting this carefully curated messaging for each branch.

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit 874a3b0 into elastic:main May 13, 2024
2 checks passed
@karenzone karenzone deleted the 16145-snmp-expectations branch May 13, 2024 14:30
@karenzone
Copy link
Contributor Author

8216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants