enable http2 for the home function test suite

scripts/functional_test_runner.js

@@ -6,6 +6,5 @@
  * Side Public License, v 1.
  */
 
-process.isFtrRunner = true;
 require('../src/setup_node_env');
 require('@kbn/test').runFtrCli();

scripts/functional_tests.js

@@ -6,6 +6,5 @@
  * Side Public License, v 1.
  */
 
-process.isFtrRunner = true;
 require('../src/setup_node_env');
 require('@kbn/test').runTestsCli();

src/setup_node_env/exit_on_warning.js

@@ -119,7 +119,7 @@ function shouldIgnore(warn) {
     col,
     ftrOnly,
   }) {
-    if (ftrOnly && !process.isFtrRunner) return false;
+    if (ftrOnly && !process.env.IS_FTR_RUNNER) return false;
     if (name && name !== warn.name) return false;
     if (code && code !== warn.code) return false;
     if (message && message !== warn.message) return false;

test/common/configure_http2.ts

@@ -14,9 +14,14 @@ type ConfigType = Record<string, any>;
 /**
  * Enables HTTP2 by adding/changing the appropriate config settings
  *
- * note: it DOES mutate the provided config.
+ * Important: this must be used on "final" (non-reused) configs, otherwise
+ * the override from the children configs could remote the overrides
+ * done in that helper.
  */
 export const configureHTTP2 = (config: ConfigType): ConfigType => {
+  // Add env flag to avoid terminating on NODE_TLS_REJECT_UNAUTHORIZED warning
+  process.env.IS_FTR_RUNNER = 'true';
+
   // tell native node agents to trust unsafe certificates
   // this is ugly, but unfortunately required, as some libraries (such as supertest)
   // have no real alternatives to accept self-signed certs

test/functional/apps/home/config.ts

@@ -7,12 +7,13 @@
  */
 
 import { FtrConfigProviderContext } from '@kbn/test';
+import { configureHTTP2 } from '../../../common/configure_http2';
 
 export default async function ({ readConfigFile }: FtrConfigProviderContext) {
   const functionalConfig = await readConfigFile(require.resolve('../../config.base.js'));
 
-  return {
+  return configureHTTP2({
     ...functionalConfig.getAll(),
     testFiles: [require.resolve('.')],
-  };
+  });
 }

test/functional/config.base.js

@@ -8,12 +8,11 @@
 
 import { pageObjects } from './page_objects';
 import { services } from './services';
-import { configureHTTP2 } from '../common/configure_http2';
 
 export default async function ({ readConfigFile }) {
   const commonConfig = await readConfigFile(require.resolve('../common/config'));
 
-  return configureHTTP2({
+  return {
     pageObjects,
     services,
 
@@ -482,5 +481,5 @@ export default async function ({ readConfigFile }) {
       },
       defaultRoles: ['test_logstash_reader', 'kibana_admin'],
     },
-  });
+  };
 }