-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiFormLayout (1/3) #7954
Commits on Aug 8, 2024
-
Delete now-unused icon number classes/utils
- entirely replaced by new `getIconAffordanceStyles` util, and CSS variables
Configuration menu - View commit details
-
Copy full SHA for 7101ad2 - Browse repository at this point
Copy the full SHA 7101ad2View commit details -
Convert
.euiFormControlLayout__childrenWrapper
to Emotion+ remove unused euiButtonEmpty styles?? literally not sure what this is doing, button empty does not have borders. probably left over from old theme + reorder imports
Configuration menu - View commit details
-
Copy full SHA for bc8380f - Browse repository at this point
Copy the full SHA bc8380fView commit details -
Convert compressed & width modifier styles
- prefer using variables over mixins which contain unnecessary CSS
Configuration menu - View commit details
-
Copy full SHA for 6d89ad9 - Browse repository at this point
Copy the full SHA 6d89ad9View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e163e78 - Browse repository at this point
Copy the full SHA e163e78View commit details -
Remove readOnly modifier styles
- most of the underlying inputs should already be setting their own styles without this component needing to (tested on all components) - the background color also doesn't need to be set, that's specific to group styles anyway - I removed the input border color change on readOnly as it doesn't match the default inputs - the border/box-shadow color stays the same for those, so I wanted that here as well
Configuration menu - View commit details
-
Copy full SHA for 5455edf - Browse repository at this point
Copy the full SHA 5455edfView commit details -
- border/background + extend `euiFormControlDefaultShadow` to allow passing only the box-shadow border and not the background gradient
Configuration menu - View commit details
-
Copy full SHA for 544c7f1 - Browse repository at this point
Copy the full SHA 544c7f1View commit details -
- remove need for compressed/uncompressed CSS by just using `inherit` - prefer setting a border radius + overflow hidden on the `childrenWrapper` instead of trying to set border radiuses on every possible child
Configuration menu - View commit details
-
Copy full SHA for b03f81a - Browse repository at this point
Copy the full SHA b03f81aView commit details
Commits on Aug 11, 2024
-
Convert append/prepend label styles to Emotion
- [opinionated change] Add a `<div>` append/prepend wrapper instead of using `React.cloneElement` - less fragile and a better pattern - use `:not:has` CSS to set padding on the wrapper instead of directly on child elements - set heights on buttons and text more explicitly - update form variables to be more specific and remove the unused border var
Configuration menu - View commit details
-
Copy full SHA for 251bad7 - Browse repository at this point
Copy the full SHA 251bad7View commit details -
Remove now-unnecessary EuiFormControlLayout specificity overrides
+ remove extra unnecessary border-radius logic in EuiComboBox - now already handled by EuiFormControlLayout
Configuration menu - View commit details
-
Copy full SHA for cf6f74f - Browse repository at this point
Copy the full SHA cf6f74fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc408a - Browse repository at this point
Copy the full SHA 5fc408aView commit details -
Fix failing test caused by
nswapi
- works correctly in browser but causes test failures - `:has()` support is apparently flaky, so we need to pin/revert the resolution
Configuration menu - View commit details
-
Copy full SHA for d92e40d - Browse repository at this point
Copy the full SHA d92e40dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 588aa0b - Browse repository at this point
Copy the full SHA 588aa0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f755e3c - Browse repository at this point
Copy the full SHA f755e3cView commit details -
[storybook] Fix EuiFormControlLayout playground
- several props (the ones destructured and re-spread to `<EuiFieldText />`) were not correctly updating the actual control - note: this was already broken in prod
Configuration menu - View commit details
-
Copy full SHA for 267ea25 - Browse repository at this point
Copy the full SHA 267ea25View commit details -
Configuration menu - View commit details
-
Copy full SHA for d80e50e - Browse repository at this point
Copy the full SHA d80e50eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 389935b - Browse repository at this point
Copy the full SHA 389935bView commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8611ac8 - Browse repository at this point
Copy the full SHA 8611ac8View commit details -
Revert "Fix failing test caused by
nswapi
"This reverts commit d92e40d.
Configuration menu - View commit details
-
Copy full SHA for e19f24c - Browse repository at this point
Copy the full SHA e19f24cView commit details