Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Create new internal util for rendering semantic <a>/<button> elements #7533

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[Tech debt] Create new internal util for rendering semantic <a>/<button> elements #7533

wants to merge 10 commits into from

Commits on Feb 16, 2024

  1. [organization] Rename src/services/security to src/services/links 

    - all logic is related to links, and I'm shortly about to add some DRY logic that is link adjacent but not security adjacent that will use these utils, so it feels like it makes sense to group them all together
    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8f263eb View commit details
    Browse the repository at this point in the history

  2. Export validateHref as top-level service 

    - and update component imports
    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8db3b92 View commit details
    Browse the repository at this point in the history

  3. Create a new DRY RenderLinkOrButton util component

    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    935de0e View commit details
    Browse the repository at this point in the history

  4. Handle Emotion css output/order 

    - gets slightly messed by the new component, we need to semi-brute-force it
    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    17b6ecd View commit details
    Browse the repository at this point in the history

  5. [EuiLink] Convert to use new utility 

    + migrate Enzyme tests
    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    35faedb View commit details
    Browse the repository at this point in the history

  6. [EuiLink] Remove now-unnecessary element-specific props

    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    648e298 View commit details
    Browse the repository at this point in the history

  7. [EuiLink] Add API for rendering conditional disabled styles

    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    3625ab1 View commit details
    Browse the repository at this point in the history

  8. [EuiLink][perf] Memoize fn calls

    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    78d91e6 View commit details
    Browse the repository at this point in the history

  9. [EuiButtonDisplay] Convert to use new utility

    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    abac60c View commit details
    Browse the repository at this point in the history

  10. [EuiButton] Remove element prop 

    - the component will now automatically detect this
    @cee-chen
    cee-chen committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    3d3453d View commit details
    Browse the repository at this point in the history