Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] DRY out scrolling/scrollbar detections and add scroll border overlays #5563

Merged
merged 9 commits into from
Jan 27, 2022
Merged

[EuiDataGrid] DRY out scrolling/scrollbar detections and add scroll border overlays #5563

merged 9 commits into from
Jan 27, 2022

Commits on Jan 25, 2022

  1. Add new useScrollBars helper 

    - to DRY out various concerns that account for scrolling & scroll bars
    @cee-chen
    cee-chen committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2b9429d View commit details
    Browse the repository at this point in the history

  2. DRY out useUnconstrainedHeight's scrollbar height calculation

    @cee-chen
    cee-chen committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    18ee38e View commit details
    Browse the repository at this point in the history

  3. DRY out scrollCellIntoView's grid scrolling check

    @cee-chen
    cee-chen committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    23a776c View commit details
    Browse the repository at this point in the history

  4. Add borders for scrolling grids and grids with scrollbars

    @cee-chen
    cee-chen committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8f4cda9 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @cee-chen
    cee-chen committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2655cf5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Correctly account for gridStyle.border

    @cee-chen
    cee-chen committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    60eac2e View commit details
    Browse the repository at this point in the history

  2. [misc] Ensure EuiPanel examples properly clip on rounded borders

    @cee-chen
    cee-chen committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    f7a7eba View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. [PR feedback] Fix fullscreen mode scroll overlay duplication 

    - By converting the pagination border to a box-shadow and tweaking z-indices to better reflect overlapping behavior
    @cee-chen
    cee-chen committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    612ae0e View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Improve useScrollBars unit tests 

    - make height/width comparisons more explicit, make mockOuterGrid less opinionated
- add both true/false comparisons for hasVerticalScroll and hasHorizontalScroll
    @cee-chen
    cee-chen committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    34a531a View commit details
    Browse the repository at this point in the history