[EuiCombobox] Add autocomplete="off" (#7842)

elastic · Jun 20, 2024 · a7f6d84 · a7f6d84
1 parent 02113bc
commit a7f6d84
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/packages/eui/changelogs/upcoming/7842.md b/packages/eui/changelogs/upcoming/7842.md
@@ -0,0 +1,2 @@
+- Updated `EuiComboBox` to no longer autocomplete searched text when used within forms
+
diff --git a/packages/eui/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap b/packages/eui/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap
@@ -25,6 +25,7 @@ exports[`EuiComboBox renders 1`] = `
             aria-expanded="false"
             aria-invalid="false"
             aria-label="aria-label"
+            autocomplete="off"
             class="euiComboBox__input"
             data-test-subj="comboBoxSearchInput"
             id="generated-id__eui-combobox-id"
@@ -82,6 +83,7 @@ exports[`EuiComboBox renders the options list dropdown 1`] = `
                 aria-controls="generated-id_listbox"
                 aria-expanded="true"
                 aria-invalid="false"
+                autocomplete="off"
                 class="euiComboBox__input"
                 data-test-subj="comboBoxSearchInput"
                 id="generated-id__eui-combobox-id"

diff --git a/packages/eui/src/components/combo_box/combo_box_input/combo_box_input.tsx b/packages/eui/src/components/combo_box/combo_box_input/combo_box_input.tsx
@@ -368,6 +368,7 @@ export class EuiComboBoxInput<T> extends Component<
               placeholder={showPlaceholder ? placeholder : undefined}
               value={this.searchValue}
               autoFocus={autoFocus}
+              autoComplete="off"
               // Force the menu to re-open on every input click - only necessary when plain text
               onClick={this.asPlainText ? (onFocus as any) : undefined} // Type shenanigans - event should be mostly the same
             />