[9.4] Fix backwards read of _ignored_source doc values (#157798) - #157826
Merged
elasticsearchmachine merged 2 commits intoAug 27, 2026
Conversation
IgnoredSourceRowStrideReader reported canReuse() == true unconditionally, but since _ignored_source moved into binary doc values the reader holds a forward-only doc values iterator. That let ValuesSourceReaderOperator reuse it for a document it had already passed, which read whichever binary block was still loaded and threw ArrayIndexOutOfBoundsException for a negative index into the block. Track the last document read and check thread affinity, matching BlockDocValuesReader and BlockSourceReader. The stored field formats keep no position of their own, so they continue to always reuse. Also assert the block-relative index is non-negative in BinaryDecoder, so a future canReuse bug fails loudly instead of silently returning another document's bytes.
jordan-powers
added
:StorageEngine/ES|QL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.4: