Ensure that synthetic _id is usable after restarts/relocations #138678
+1,127
−554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcofdez
added
>enhancement
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Collaborator
|
Hi @fcofdez, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
SyntheticIdFieldto be an indexed field but with an emptyTokenStreamto ensure that there's minimal work done while indexing synthetic _id fields. The reason for the change is that Lucene ensures that the schema is consistent across all the segments and new documents, and before we used to modify the_idFieldInfoat read time to ensure that the field is considered as indexed to allow update/deletes, but once a new document is added, it will haveIndexOptions.NONEand Lucene would throw an exception.In addition to such changes, there's some small code reorganization and simplification.
This PR depends on #138515