Add shard write-load to cluster info #131496
Open
+173
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
Team:Distributed Coordination
nicktindall
commented
Jul 18, 2025
| @@ -527,8 +538,6 @@ public ClusterInfo getClusterInfo() { | |||
| estimatedHeapUsages.put(nodeId, new EstimatedHeapUsage(nodeId, maxHeapSize.getBytes(), estimatedHeapUsage)); | |||
| } | |||
| }); | |||
| final Map<String, NodeUsageStatsForThreadPools> nodeThreadPoolUsageStats = new HashMap<>(); | |||
| nodeThreadPoolUsageStatsPerNode.forEach((nodeId, nodeWriteLoad) -> { nodeThreadPoolUsageStats.put(nodeId, nodeWriteLoad); }); | |||
There was a problem hiding this comment.
This appeared to be just a copy, which already happens in the ClusterInfo constructor, I assume remnants of something that was since refactored away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use
TransportIndicesStatsActionto retrieve size on disk for the disk threshold decider.This PR just adds the
Indexingstats to that request when the write load decider is enabled, and adds the returned shard write loads to theClusterInfo.We should be able to feed these into the simulator to properly account for shard movement.
Relates: ES-12419 & ES-12420