Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Prevent DLS/FLS if replication is assigned #108839

Merged
merged 8 commits into from
May 22, 2024

Conversation

jakelandis
Copy link
Contributor

@jakelandis jakelandis commented May 20, 2024

this commit adds documentation for the DLS/FLS restriction for RCS 2.0 API keys where both access and replication are defined and access has DSL/FLS.

this commit also fixes a few misleading variable names.

related: #108600

Copy link

Documentation preview:

@jakelandis jakelandis added >docs General docs changes v8.14.0 labels May 20, 2024
@jakelandis jakelandis requested a review from n1v0lg May 20, 2024 21:11
@jakelandis jakelandis marked this pull request as ready for review May 20, 2024 21:11
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label May 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates! provided some grammar/style recommendations

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one semantic correction.

==== Field and document level security with Cross-cluster API keys

<<security-api-create-cross-cluster-api-key, Cross-Cluster API keys>> can be used to authenticate
requests to a remote cluster.`access` provides access for Cross Cluster Search.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want search instead of access here and throughout the paragraphs below.

jakelandis and others added 2 commits May 21, 2024 11:38
suggested changes

Co-authored-by: Nikolaj Volgushev <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for this!

@jakelandis jakelandis added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label May 22, 2024
@jakelandis jakelandis merged commit ff92296 into elastic:main May 22, 2024
15 checks passed
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request May 22, 2024
This commit adds documentation for the DLS/FLS restriction for RCS 2.0 API keys 
where both access and replication are defined and access has DSL/FLS.
This commit also fixes a few misleading variable names.
related: elastic#108600
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14

elasticsearchmachine pushed a commit that referenced this pull request May 22, 2024
This commit adds documentation for the DLS/FLS restriction for RCS 2.0 API keys 
where both access and replication are defined and access has DSL/FLS.
This commit also fixes a few misleading variable names.
related: #108600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes Team:Docs Meta label for docs team v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants