nativeaccess: try to load all located libsystemds #108238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux systems with multiarch (e.g. i386 & x86_64) libraries may have libsystemd.0 in two subdirectories of an entry in java.library.path. For example, libsystemd.so.0 may be found in both /usr/lib/i386-linux-gnu and /usr/lib/x86_64-linux-gnu. Instead of attempting to load any library found, attempt all and stop as soon as one is successfully loaded.
elasticsearchmachine
added
v8.15.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @axw, I've created a changelog YAML for you. |
ldematte
reviewed
May 3, 2024
libs/native/src/main21/java/org/elasticsearch/nativeaccess/jdk/JdkSystemdLibrary.java
Outdated
Show resolved
Hide resolved
rjernst
reviewed
May 3, 2024
There was a problem hiding this comment.
The general pattern of trying multiple paths seems ok, but I would like to keep a separation of loading from identifying possible paths. Could we please keep the method findLibSystemd, but change it to return a List? Then that can be looped over in the same static block that already tries to load.
|
@axw One of test failures is due to tabs being present, can you please check indentation is with spaces? |
|
@elasticsearchmachine update branch |
|
😢 so many different lint/check/spotless apply commands. Working on it, sorry. |
|
@rjernst all good now, sorry for that. PTAL. |
rjernst
approved these changes
May 8, 2024
rjernst
added
v8.14.1
auto-backport-and-merge
💚 Backport successful
|
axw
added a commit
to axw/elasticsearch
that referenced
this pull request
May 8, 2024
Linux systems with multiarch (e.g. i386 & x86_64) libraries may have libsystemd.0 in two subdirectories of an entry in java.library.path. For example, libsystemd.so.0 may be found in both /usr/lib/i386-linux-gnu and /usr/lib/x86_64-linux-gnu. Instead of attempting to load any library found, attempt all and stop as soon as one is successfully loaded.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2024
Linux systems with multiarch (e.g. i386 & x86_64) libraries may have libsystemd.0 in two subdirectories of an entry in java.library.path. For example, libsystemd.so.0 may be found in both /usr/lib/i386-linux-gnu and /usr/lib/x86_64-linux-gnu. Instead of attempting to load any library found, attempt all and stop as soon as one is successfully loaded.
markjhoy
pushed a commit
to markjhoy/elasticsearch
that referenced
this pull request
May 9, 2024
Linux systems with multiarch (e.g. i386 & x86_64) libraries may have libsystemd.0 in two subdirectories of an entry in java.library.path. For example, libsystemd.so.0 may be found in both /usr/lib/i386-linux-gnu and /usr/lib/x86_64-linux-gnu. Instead of attempting to load any library found, attempt all and stop as soon as one is successfully loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux systems with multiarch (e.g. i386 & x86_64) libraries may have libsystemd.0 in two subdirectories of an entry in java.library.path. For example, libsystemd.so.0 may be found in both /usr/lib/i386-linux-gnu and /usr/lib/x86_64-linux-gnu.
Instead of attempting to load any library found, attempt all and stop as soon as one is successfully loaded.
Fixes #107878