Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout of assertBusy in DeprecationHttpIT for remaining places #108229

Merged
merged 1 commit into from May 6, 2024

Conversation

mosche
Copy link
Contributor

@mosche mosche commented May 3, 2024

Checking the sporadic failures since DeprecationHttpIT was enabled again, there wasn't any leaks anymore.
However, there's two places left with the default timeout of assertBusy, causing occasional failures of

Expected: a collection with size <2>
     but: collection size was <0>

relates to #101596

@mosche mosche added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team labels May 3, 2024
@mosche mosche marked this pull request as ready for review May 6, 2024 13:18
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit 609f5f8 into elastic:main May 6, 2024
15 checks passed
@mosche mosche deleted the DeprecationHttpIT_timeout branch May 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants