Skip to content

Add InfoSec's pre-commit hook for secrets detection #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add InfoSec's pre-commit hook for secrets detection #8010

wants to merge 2 commits into from
+20 −9

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR adds the pre-commit hook for detecting if secrets are being committed, as recommended by Elastic's InfoSec team.

Why is it important?

To prevent secrets from committed to the Elastic Agent repository.

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements backport-active-all Automated backport with mergify to all the active branches labels Apr 28, 2025
@ycombinator ycombinator requested a review from a team as a code owner April 28, 2025 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

christophercutajar
christophercutajar previously approved these changes Apr 28, 2025
View reviewed changes
Copy link

@christophercutajar christophercutajar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cc @ycombinator

pkoutsovasilis
pkoutsovasilis reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first see the pre-commit not failing and then merge this, right? 🙂

@ycombinator
Copy link
Contributor Author

Just a heads up: @christophercutajar is looking into a fix to the failure we're seeing in CI:

fatal: could not read Username for 'https://github.com/': No such device or address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoutsovasilis pkoutsovasilis pkoutsovasilis left review comments

@cmacknz cmacknz cmacknz approved these changes

@christophercutajar christophercutajar christophercutajar left review comments

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@ycombinator ycombinator

Labels
backport-active-all Automated backport with mergify to all the active branches chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ycombinator @elasticmachine @cmacknz @pkoutsovasilis @christophercutajar