Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] Remove unused section from packing spec #4182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR removes the MacOS section from the packaging spec file because that section is never actually used in packaging.

Why is it important?

To avoid confusion.

How to test this PR locally

  1. Package Elastic Agent with this PR.

    SNAPSHOT=true PLATFORMS=darwin/arm64 PACKAGES=targz mage package
  2. Unpack and install agent.

    cd /tmp
    tar xzf $OLDPWD/build/distributions/elastic-agent-8.13.0-SNAPSHOT-darwin-aarch64.tar.gz
    cd elastic-agent-8.13.0-SNAPSHOT-darwin-aarch64
    sudo ./elastic-agent install -n
  3. Check that the Agent reports a healthy status.

    sudo elastic-agent status
  4. Check that uninstallation works.

    sudo elastic-agent uninstall -f

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a leftover from whenever agent/beats packages for MacOS were created.
Since it's not used in current packaging we can safely get rid of it

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants