Skip to content

test: close files after use #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

kruskall
Copy link
Member

What does this PR do?

resolve a few file leak in tests

Why is it important?

we should avoid leaking files, even in tests

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

resolve a few file leak in tests
@kruskall kruskall requested a review from a team as a code owner June 13, 2025 14:22
@kruskall kruskall requested review from belimawr and VihasMakwana and removed request for a team June 13, 2025 14:22
@kruskall kruskall changed the title test: add defer func to close files test: add close files after use Jun 13, 2025
@kruskall kruskall changed the title test: add close files after use test: close files after use Jun 13, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants