Reduce CPU consumption and heap allocations of SubsystemMountpoints() #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reduces memory allocations and thus GC activity in a hot path (
SubsystemMountpoints()
).It also adds a benchmark that can be run with
Benchmark results Before
Benchmark results After
It became aware when looking at the Universal Profiling flamegraph for
auditbeat
thatSubsystemMountpoints()
was consuming ~25% of the CPU usage ofauditbeat
. Additionally, it created a lot of unneeded heap allocations for temporary (function-local) variables. The GC ate another ~21% of the total CPU consumption ofauditbeat
.Screenshot (data from a real set of >200 Elasticsearch clusters)
Why is it important?
As long running applications, the beats should consume as less CPU as possible.
Checklist