Add functionality for pandas_to_eland to handle columns with .
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashton-Sidhu
changed the title
pandas_to_eland to handle columns with .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #418
This PR adds the functionality to handle nested Elasticsearch fields and ETL processes that have dataframes that use periods in column names that map to nested fields in the Elastic mapping.
Instead of trying to take each column with a
.in the pandas dataframe, create a nested mapping to map the Elasticsearch mapping format and change theverify_mapping_compatabilityfunction to be able to compare nested schemas - I took the Elastic mapping schema and then compressed it so it'scolumn_name: type( ex.{"a.b.c.d": {"type": "long"}}). This significantly simplified the implementation.