Add tqdm to pandas_to_eland() #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
V1NAY8
force-pushed
the
add-tqdm
branch
2 times, most recently
from
c22fcd3
to
f1d7824
Compare
|
Added tests, updated |
sethmlarson
suggested changes
Nov 16, 2020
|
Yep @sethmlarson , Made changes, |
|
I'll handle the elasticsearch-py stuff, there's a subtle change that needs to be made regarding which elasticsearch-py version to install |
|
Ask jenkins to test this please |
|
jenkins test this please |
|
Also I took reference for ipython check from |
|
@sethmlarson Anything else required on this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294
Added tqdm functionality for
pandas_to_eland()If we want the progress bar to disappear we will need to just add
leave=Falseto tqdm context manager at line 234@sethmlarson
Please review if the implementation is correct, I will add notebook tests for this once review is done. 馃槂