Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the wmi beats module 42650 #42663

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Improve the wmi beats module 42650 #42663

wants to merge 22 commits into from
+382 −202

Conversation

herrBez
Copy link
Contributor

@herrBez herrBez commented Feb 10, 2025

Proposed commit message

Improve the WMI Module Documentation
Add the domain parameter

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@herrBez
Add the Domain parameter. Remove reference to the IP address
f1f09e7
@herrBez
Merge branch 'main' of github.com:elastic/beats into improve-the-wmi-…
64d5706 
…beats-module-42650
@herrBez
Add the domain to the wmi data
30a5f45
@herrBez
Improve the documentation of the WMI module
1186460 
- Add [float] to the internal sections
- Mention all parameters
- Make sure the examples has two queries and one of them uses where and
  namespace
- Show an example of how to convert an WQL query into a YAML
  Configuration
@herrBez herrBez requested a review from ishleenk17 February 10, 2025 19:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @herrBez? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@herrBez herrBez added backport-8.x Automated backport to the 8.x branch with mergify Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Feb 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2025
herrBez and others added 14 commits February 12, 2025 14:58
@herrBez @ishleenk17
Update metricbeat/module/windows/wmi/_meta/docs.asciidoc
5eff223 
Co-authored-by: Ishleen Kaur <[email protected]>
@herrBez @ishleenk17
Update metricbeat/module/windows/wmi/_meta/docs.asciidoc
461c09a 
Co-authored-by: Ishleen Kaur <[email protected]>
@herrBez
Add wmi.namespace and rewrite the Configuration section
1cf6ef4
@herrBez
Add section about best-practice and about Arbitrator
77ab16b
@herrBez
Improve phrasing of the best practices section
d8f479d
@herrBez
Fix the convertDateTime function and add a test for the dates with ti…
09a0c2e 
…mezone
@herrBez
Refactor replace fields with properties to be compliant with WMI docu…
1fe7f2e 
…mentation
@herrBez
Refactor the wmi.include_null and wmi.include_empty_string to a more …
4ed5563 
…explicit wmi.include_null_properties and wmi.include_empty_string
@herrBez
Run make update
afbced1
@herrBez
Make the warning more accurate
c35c1e7
@herrBez
Fix typo
0974350
@herrBez
Fix linting error
43af227
@herrBez
fix the example of the documentation + reorder the parameter definiti…
e05a887 
…on to be the same of the example
@herrBez
Merge branch 'main' into improve-the-wmi-beats-module-42650
2c23092
@herrBez herrBez requested a review from strawgate February 19, 2025 09:34
@herrBez herrBez requested a review from ishleenk17 February 19, 2025 11:16
@herrBez herrBez marked this pull request as ready for review February 20, 2025 07:07
@herrBez herrBez requested review from a team as code owners February 20, 2025 07:07
@herrBez herrBez requested a review from mauri870 February 20, 2025 07:07
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 21, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested a review from faec February 21, 2025 08:03
mauri870
mauri870 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not very familiar with this part of the codebase. Since Fae approved it, that should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauri870 mauri870 mauri870 approved these changes

@faec faec faec approved these changes

@tommyers-elastic tommyers-elastic Awaiting requested review from tommyers-elastic

@strawgate strawgate Awaiting requested review from strawgate

@ishleenk17 ishleenk17 Awaiting requested review from ishleenk17

At least 1 approving review is required to merge this pull request.

Assignees

@herrBez herrBez

Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the WMI Beats Module
6 participants
@herrBez @elasticmachine @mauri870 @faec @ishleenk17 @pierrehilbert