Add delete button to "video details" #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
LukasKalbertodt
requested changes
Jun 5, 2024
github-actions
bot
removed
the
status:conflicts
owi92
force-pushed
the
deleting-videos
branch
2 times, most recently
from
8a6d81d
to
00b6d31
Compare
LukasKalbertodt
requested changes
Jun 11, 2024
LukasKalbertodt
approved these changes
Jun 11, 2024
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
|
This pull request has conflicts ☹ |
github-actions
bot
added
the
status:conflicts
backend/src/api/model/event.rs
Outdated
Comment on lines
348
to
353
| .delete_event(&event.opencast_id) | ||
| .await | ||
| .map_err(|e| { | ||
| error!("Failed to send delete request: {}", e); | ||
| err::internal!("Failed to communicate with Opencast") | ||
| })?; |
There was a problem hiding this comment.
I just tested this and the resulting shown error is not ideal I think.
I think it would be nicer if instead it would say something like "Deleting the video failed. Opencast is currently not available, try again later". I think I would even introduce a new "error kind" OpencastDown or sth like that, as to not use internal server error for this (unauthorized and bad input are also not fitting).
backend/src/api/model/event.rs
Outdated
| "Failed to delete event, OC returned status: {}", | ||
| response.status() | ||
| ); | ||
| Err(err::internal!("Opencast API error: {}", response.status())) |
There was a problem hiding this comment.
Same as above: not internal error, but sth like "opencast down".
This migration also renames the `events` table and creates a new view holding all events without the deletion timestamp. This is done out of convenience as to avoid having to adjust every query with a check for that deletion timestamp.
This is necessary in order to make authenticated http request in graphQL mutations and other api calls.
github-actions
bot
removed
the
status:conflicts
The underlying function calls the external OC event API to request the deletion of a single video and sets the `tobira_deletion_timestamp` in the video's DB entry. Unfortunately this API can't tell us if the deletion succeeded, only that the retraction of the event was started. That check and the following removal from the DB is done by inspecting the previously mentioned timestamp (implemented in the next commit).
"My Videos" will now indicate if a video has been deleted in Tobira, but not (yet) in Opencast. After the request has been sent, the deleted video will be marked as "delete pending". When the event hasn't been removed in sync after a minute, the deletion in Opencast has probably failed, so it gets marked accordingly.
LukasKalbertodt
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "delete" button to the "Video details" page which will remove that event in Tobira and send a
deleterequest to Opencast. While that operation is pending and when it fails on Opencast side, the event will still be visible on the "My Videos" page marked respectively, but only there and only as long as it is still present in Opencast. Tobira's sync code will pick up if it gets eventually deleted, and then the "pending/ deletion failed" event will be removed completely.See commits for more technical details.
Should be fine to review commit by commit.
Closes #806