Address some screen reader issues #1134
Conversation
These already have tooltips that are read by screenreaders, but without explicit labels the wave plugin still complains. Might be relevant for SEO or sth (but honestly, I doubt that).
Previously, certain form inputs would always be labelled by their error message, which only exists if there's an error (big surprise, I know). This would cause the wave plugin to show an error like "broken aria reference" if there were no errors.
Instead of announcing that the recording has started, I think it's ok to announce the updated description of the record-button, which should be focused when pressed, instead.
With this, screenreaders will tell the user that they're going to share the selected media instead of just reading the tile's label. Also unifies some translation names.
owi92
force-pushed
the
screen-reader-issues
branch
from
f0cef81
to
83af9bf
Compare
There was a problem hiding this comment.
Very nice work! Also thanks for commentnig with additional information on the issue.
The code looks good and most things also work in my Ubuntu screen reader. However:
- "Make aria-labelledby prop state dependent" doesn't make a difference for me. The label was already announced correctly before.
- "Mark recording button as aria-live region" unfortunately doesn't work for me. Nothing is announced when starting or pausing the recording.
However, I think we can easily blame that on the Ubuntu screen reader implementation. if these commits improve the situation for the macOS screen reader (which most certainly is used a whole lot more!) then it's an improvement.
With that argument, I will just merge this without waiting for more reviewers with different screen readers, as this clearly improves quite a few things and is unlikely to make things worse. A proper accessibility review is planned anyway.
Same here, this was just about appeasing the wave plugin. |
Addresses some of the issues outlined in #1074
Also fixes some complaints made by the wave plugin.
I have left a comment over there regarding the ones not included here.