feat(golangcilint): add formatting capabilities #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
golangci-fmt
branch
from
a472112 to
5a31651
Compare
fredrikaverpil
force-pushed
the
golangci-fmt
branch
from
5a31651 to
b2a2e3d
Compare
joaoeinride
reviewed
Mar 26, 2025
| if err != nil { | ||
| return err | ||
| } | ||
| if d.IsDir() || d.Name() != "go.mod" { |
There was a problem hiding this comment.
Suggested change
| if d.IsDir() || d.Name() != "go.mod" { | |
| if d.IsDir() || d.Name() == "go.mod" { |
or ideally check the file extension is .go?
fredrikaverpil
force-pushed
the
golangci-v2
branch
3 times, most recently
from
df59ac3 to
eef925f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
golangci-lint fmtis a new command in golangci-lint v2.What?
sggolangcilint.Fmtandsggolangcilint.FmtFixfunctions.sggolangcilint.Fmtinstead ofsggolines.Formatfrommain.go.make go-format-fixto fix the files which are in need of formatting.Notes
FmtandFmtFixis that the--diffargument is passed into the former. I think, however, it is clearer to provide these two explicit functions. But if you disagree, we can just call theFmtfunction with a--diffargument for checking and omitting it for writing.