New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eigenric/develop #1

Merged

eigenric merged 3 commits into eigenric:develop from micahellison:eigenric/develop

May 11, 2024

micahellison commented May 10, 2024

Hi @eigenric, thanks for your jrnl PR. I'm just adding some housekeeping and tests to it:

running poe format to get past the linter
Fixing a unit test that expected a single -contains value
Adding BDD tests with against our usual test journals for your fix

micahellison added 3 commits

May 10, 2024 07:19


          Run poe format

989f504


          Fix unit test for contains to allow list instead of single value

beb8608


          Add BDD tests for multiple contains with and without -and

799fb8d

eigenric merged commit f17a857 into eigenric:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet