Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize repo and add Rational #1

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Initialize repo and add Rational #1

merged 10 commits into from
Dec 6, 2024

Conversation

Alex-Fischman
Copy link
Collaborator

This PR initializes the repository and moves Rational from egglog to this repo.

@Alex-Fischman Alex-Fischman requested a review from oflatt December 4, 2024 22:48
oflatt
oflatt approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume rational.rs is just copied over.
Just need to point to particular commit on main before merging

Cargo.toml Outdated Show resolved Hide resolved
@oflatt
Copy link
Member

oflatt commented Dec 4, 2024

Would love to see a README in a follow up!

@Alex-Fischman Alex-Fischman merged commit 8d3f10b into main Dec 6, 2024
4 checks passed
@Alex-Fischman Alex-Fischman deleted the add-rational branch December 6, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Fischman @oflatt