ftdetect, add *.zone* to filetype bind-named #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egberts
reviewed
Sep 26, 2021
| @@ -11,4 +11,4 @@ | |||
| " Remarks: | |||
| " See syntax/bind-named.vim for additional info. | |||
|
|
|||
| au! BufNewFile,BufRead named.conf,rndc.conf,rndc.key,*-named.conf,*_named.conf,*.named.conf,named-*.conf,named_*.conf,named.*.conf,rndc-*.conf,rndc_*.conf,rndc.*.conf,rndc.key,rndc-*.key,rndc_*.key,rndc.key,mz.*,sz.*,view.*,named.conf* set filetype=bind-named | |||
There was a problem hiding this comment.
*.zone* isn’t going to sit well with the public space of filename matching in the general Vim community. It will catch a lot of files having .zone in the middle of the a filename. The false positive would be too uncomfortable for this plugin to take as-is. (risk alienating the end-users to removing this plugin.
Can we do zone.* or *.zone ? Or both?
There was a problem hiding this comment.
You are right, it could break something, i didn't think about this. It worked for me, so i thought to give my changes back 🙂
I have .zone and .zones files, so i would suggest to add *.zone and *.zones, but it's up to you.
| else | ||
| " noexpandtab got defined elsewhere, so we use hard tab, locally | ||
| echomsg "Expandtabby..." |
There was a problem hiding this comment.
Good catch on this one. I too was a victim of overplugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you a lot for your vim syntax highlight.
I have different zones, each in it's own file, so i thought i extend the ftdetect and create a pull request :)