ballistica in docker :o

[Loup-Garou911XD]

Steps

• Write a good description of what your PR does (and WHY it does it).
• Add yourself to CONTRIBUTORS if you are a new contributor.
• Add a CHANGELOG entry if your change is non-trivial.
• Ensure make preflight completes successfully.

Description

Added build system for docker which builds docker image with bombsquad server which could be deployed easily with docker on any system
Added docker-build and docker-run targets to make file

Type of Changes

	Type
✓	✨ New feature

[MW2917]

so I have to write my fix into changelog with PR?

[Loup-Garou911XD]

so I have to write my fix into changelog with PR?

yeah u should

[Loup-Garou911XD]

@efroemling https://github.com/efroemling/ballistica/actions/runs/9140752345/job/25134432953?pr=698#step:5:23
what to do bout this?
i checked tools/batools/spinoff/_context.py and it doesn't have the sphinx dir anymore so idk

[efroemling]

@efroemling https://github.com/efroemling/ballistica/actions/runs/9140752345/job/25134432953?pr=698#step:5:23 what to do bout this? i checked tools/batools/spinoff/_context.py and it doesn't have the sphinx dir anymore so idk

The src/assets dir is a bit of a complicated beast as far as spinoff rules and things like that. Can you stick the Dockerfile in config/docker/Dockerfile? I think that may fix (or least improve) things.

[Loup-Garou911XD]

@efroemling https://github.com/efroemling/ballistica/actions/runs/9140752345/job/25134432953?pr=698#step:5:23 what to do bout this? i checked tools/batools/spinoff/_context.py and it doesn't have the sphinx dir anymore so idk

The src/assets dir is a bit of a complicated beast as far as spinoff rules and things like that. Can you stick the Dockerfile in config/docker/Dockerfile? I think that may fix (or least improve) things.

Okay sure just gimme few minutes I'll push

[Loup-Garou911XD]

Also @vishal332008 requests you to come on discord

[efroemling]

@efroemling https://github.com/efroemling/ballistica/actions/runs/9140752345/job/25134432953?pr=698#step:5:23 what to do bout this? i checked tools/batools/spinoff/_context.py and it doesn't have the sphinx dir anymore so idk

The src/assets dir is a bit of a complicated beast as far as spinoff rules and things like that. Can you stick the Dockerfile in config/docker/Dockerfile? I think that may fix (or least improve) things.

Okay sure just gimme few minutes I'll push

If it's still giving you errors after that, don't worry about it; I can fix the spinoff stuff on my end after I pull the PR if that's the case.

[efroemling]

Also @vishal332008 asks you to come on discord

Also just as an FYI: the error I was seeing is that spinoff didn't know whether or not to filter the Dockerfile. Check out config/spinoffconfig.py line 142 for where it determines that. If you relocate Dockerfile to under config/docker/ then it will be covered by one of those rules (we do want it to be filtered I think).

[Loup-Garou911XD]

Also @vishal332008 asks you to come on discord

Also just as an FYI: the error I was seeing is that spinoff didn't know whether or not to filter the Dockerfile. Check out config/spinoffconfig.py line 142 for where it determines that. If you relocate Dockerfile to under config/docker/ then it will be covered by one of those rules (we do want it to be filtered I think).

filtered means not included in spinoff project?

[efroemling]

Thanks for this!

[efroemling]

Also @vishal332008 asks you to come on discord

Also just as an FYI: the error I was seeing is that spinoff didn't know whether or not to filter the Dockerfile. Check out config/spinoffconfig.py line 142 for where it determines that. If you relocate Dockerfile to under config/docker/ then it will be covered by one of those rules (we do want it to be filtered I think).

filtered means not included in spinoff project?

No; filtered just means that all instances of 'BallisticaKit' in the file are replaced with 'BombSquad' (or whatever else the project name is), and optionally other filtering is done too. Generally we want this for most things.