Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if we're knocked out, don't flail our legs and arms when airborn #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VinniTR
Copy link
Contributor

@VinniTR VinniTR commented Apr 22, 2024

Description

Let's keep this here in the meantime.

Type of Changes

Type
βœ“ πŸ› Bug fix

@VinniTR VinniTR changed the title if we're knocked out, don't flail our legs and arms if we're knocked out, don't flail our legs and arms when airborn Apr 23, 2024
@EraOSBeta
Copy link
Contributor

This can pass into scenev1 if flailing doesn't really affect anything in the physics simulation

@efroemling
Copy link
Owner

This would slightly affect physics sims in some cases: older clients would be simulating with flailing limbs while the servers they are connected to would not, so there'd be some popping and resyncing until everyone got the update. But I don't think that would be too problematic.

Rather my main question with this would be: does it make things funnier or improve gameplay? The knockout mechanism is kinda meant to just mean that a character is too stunned to stand; I don't think it breaks any logic if they still wave their arms when flying through the air. Right now one can tell at a glance if a flying character is alive or dead by whether they are flailing, but this would complicate that. And I worry that a large percentage of events that launch a character through the air would also knock them out, meaning that we could essentially just be removing flailing, which is no fun.

So anyway I'm probably against this for those reasons, but I do want to be receptive to other opinions if you feel it is an improvement.

@VinniTR
Copy link
Contributor Author

VinniTR commented Apr 29, 2024

@efroemling i think it's funny because the character would be like a rag doll every time he goes flying, whether due to a punch or an explosion, the death animation could be modified a little to avoid confusion with living and dead people, if that's what it is what you mean...

@EraOSBeta
Copy link
Contributor

@VinniTR can you show us a comparison video between the old behavior and the new one so we could compare the funni value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants