Skip to content

fix(dockerfile): update builder image #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dockerfile): update builder image #10

wants to merge 1 commit into from

Conversation

duncdrum
Copy link

@duncdrum duncdrum commented May 27, 2025 •
edited
Loading

this keeps a builder stage, but we could just as well make it a single-stage with a simple COPY or ADD with a xar.

close #4

@duncdrum
fix(dockerfile): update builder image
8f21d71 
use jinntec base image.
@duncdrum duncdrum marked this pull request as ready for review May 27, 2025 15:17
wolfgangmm
wolfgangmm reviewed Jun 16, 2025
View reviewed changes
ansible/Dockerfile.njk
{% for app in publisher.apps %}
COPY --from=tei /tmp/{{app.name}}/build/*.xar /exist/autodeploy/
COPY --from=builder --chown=${USR}/tmp/{{app.name}}/build/*.xar /exist/autodeploy/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after chown

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangmm wolfgangmm wolfgangmm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate Dockerfile from app repo
2 participants
@duncdrum @wolfgangmm