Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Unix line endings #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Unix line endings #8

wants to merge 1 commit into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 23, 2016 •
edited
Loading

This change is Reviewable

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 23, 2016

If it is helpful, I can add "dos2unix" into https://github.com/edwardsamuel/Wilayah-Administratif-Indonesia/blob/c101ef2/scripts/run.sh#L28 .
Also would be good to add CI for this, but that can be delayed until #9 and I'll ensure coala/coala-bears#815 is available soon.

@edwardsamuel
Copy link
Owner

Yes, it is better if you can add dos2unix command in the script, so in the future, all the CSV and MySQL will always have Unix line endings.

@edwardsamuel
Copy link
Owner

@jayvdb Can you fix the Dockerfile as well?
I found this error while running the script:

./run.sh: 24: ./run.sh: dos2unix: not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @edwardsamuel