Added ability to create extensions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Apr 19, 2023
editorjs.config.sample.ts
Outdated
| editorConfig: { | ||
| inlineToolbar: true, | ||
| readOnly: false, |
There was a problem hiding this comment.
it is the default value, could be removed
src/Stand/Stand.ts
Outdated
| @@ -32,6 +33,11 @@ export default class Stand { | |||
| */ | |||
| private JSData: FileData; | |||
|
|
|||
| /** | |||
| * Data to store into stand style file | |||
There was a problem hiding this comment.
Description is not clear. What kind of data?
src/Stand/StandAPI/StandAPI.ts
Outdated
| @@ -0,0 +1,18 @@ | |||
| /** | |||
| * Class for stand API, which is used to interact with editor.js wrapper | |||
There was a problem hiding this comment.
Suggested change
| * Class for stand API, which is used to interact with editor.js wrapper | |
| * Class for stand API, which is used to interact with Stand |
Comment on lines
27
to
55
| for (const extensionClass of extensions) { | ||
| /** | ||
| * Create extension | ||
| */ | ||
| const extension = new extensionClass(editor, standAPI); | ||
|
|
||
| /** | ||
| * If extension has styles, add them to the stand | ||
| */ | ||
| if (extension.styles) { | ||
| styleElement.textContent += extension.styles; | ||
| } | ||
|
|
||
| /** | ||
| * Create button to toggle extension | ||
| */ | ||
| const btn = document.createElement('button'); | ||
| btn.addEventListener('click', () => { | ||
| extension.control.onActivate(); | ||
| btn.classList.toggle('dev-stand__extensions-button--active'); | ||
| }); | ||
| btn.innerHTML = extension.control.icon; | ||
| btn.classList.add('dev-stand__extensions-button'); | ||
|
|
||
| /** | ||
| * Create container for extension | ||
| */ | ||
| const extensionContainer = document.createElement('div'); | ||
| extensionContainer.classList.add('dev-stand__extensions-item'); |
There was a problem hiding this comment.
This code could be organised better with classes or methods
|
|
||
| // {{{ Core }}} | ||
|
|
||
| const standAPI = new StandAPI('editorjs'); |
There was a problem hiding this comment.
I think editorWrapper should not be hardcoded here, but passed from somewhere as link
Co-authored-by: Peter Savchenko <[email protected]>
…s to stand, created two folders
neSpecc
reviewed
Apr 20, 2023
tsconfig.json
Outdated
Comment on lines
17
to
18
| "include": ["editorjs.config.ts", | ||
| "setup", "editorjs.config.sample.ts", "vite.config.ts", "dev-stand"], |
|
|
||
| // {{{ Core }}} | ||
|
|
||
| const standAPI = new StandAPI(editorHolderId); |
There was a problem hiding this comment.
can we pass editorHolder element instead of id? so we won't need to find it again in DOM
Co-authored-by: Peter Savchenko <[email protected]>
…ools into feature/added-extensions
neSpecc
approved these changes
Apr 20, 2023
ilyamore88
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/templatesfolderExtensiontypeStandAPIto work with editor.js wrapperstand.js