Support GEL_XXX environment variables #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
reviewed
Feb 13, 2025
elprans
reviewed
Feb 13, 2025
elprans
reviewed
Feb 13, 2025
elprans
reviewed
Feb 13, 2025
| if [ -z "${file_var_val}" ] && [ -n "${old_file_var_val}" ]; then | ||
| file_var_val="${old_file_var_val}" | ||
| unset "$old_file_var" | ||
| if [ "$var" == "GEL_SERVER_PASSWORD" ] || [ "$var" == "GEL_SERVER_PORT" ]; then |
There was a problem hiding this comment.
Because we recognize the client version of these two variables GEL_PASSWORD and GEL_PORT. But only for those two.
There was a problem hiding this comment.
Can you point to where exactly these are handled? AFAICS neither the entrypoint nor the server itself handle these.
There was a problem hiding this comment.
The usage is obfuscated with bash variable interpolation. Before this PR:
The check here would give a deprecation warning for the client form of envvars EXCEPT for EDGEDB_PORT and EDGEDB_PASSWORD see edbdocker_env_var_deprecated.
Then the value of these variables is used here.
We also use EDGEDB_PASSWORD in a test composed app works.
Co-authored-by: Elvis Pranskevichus <[email protected]>
Co-authored-by: Elvis Pranskevichus <[email protected]>
elprans
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.