Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade composer v1 to composer v2 for php 7.4 #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rsereir
Copy link

@rsereir rsereir commented Nov 1, 2020

Current version for php 7.4 is not compatible with composer v2.0

@edbizarro
Copy link
Owner

edbizarro commented Nov 3, 2020

can you remove hirak/prestissimo from the images with composer v2 too?

thanks

@rsereir
Copy link
Author

rsereir commented Nov 3, 2020

I removed this image from all php versions with composer v2, thanks for review.

@j3j5 j3j5 mentioned this pull request Nov 4, 2020
Copy link

@wedi wedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me after rebasing and resolving confilict with node v14 update.

I'd suggest to let pr #113 overtake and rebase this one afterwards and have it update composer in the PHP 8 version, too.

Edit: I'd probably remove the .idea directory.

@GlennM
Copy link

GlennM commented May 3, 2021

PR #113 has been merged, so can this one about Composer v2 be completed now?

@jacobnollette
Copy link

Any info on the conflicts?

@evs-xsarus
Copy link

Could this be added in such a way that I can choose to have composer 1 or 2 ?

Perhaps keep the current for composer 1

image: edbizarro/gitlab-ci-pipeline-php:7.4

and for composer 2:

image: edbizarro/gitlab-ci-pipeline-php:7.4-composer2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants