Skip to content

Commit

Permalink
Update Dockerfile LABEL instructions to be compatible with podman #189
Browse files Browse the repository at this point in the history
  • Loading branch information
babykart authored and edannenberg committed Jan 26, 2021
1 parent 2ffddec commit 39e0056
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions engine/docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function generate_dockerfile() {
|| die "Error while generating ${image_path}/Dockerfile"

# insert build timestamp last to preserve build cache
echo "LABEL kubler.build.timestamp ${build_timestamp}" >> "${image_path}"/Dockerfile
echo "LABEL kubler.build.timestamp=${build_timestamp}" >> "${image_path}"/Dockerfile
}

# Returns given tag value from dockerfile or exit signal 3 if tag was not found.
Expand Down Expand Up @@ -265,7 +265,7 @@ function build_image() {

_status_msg="commit ${run_id} as image ${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}"
# shellcheck disable=SC2086
pwrap 'nolog' "${DOCKER}" commit ${DOCKER_COMMIT_OPTS} -c "LABEL kubler.build.timestamp $(date '+%Y%m%d%H%M%S')" \
pwrap 'nolog' "${DOCKER}" commit ${DOCKER_COMMIT_OPTS} -c "LABEL kubler.build.timestamp=$(date '+%Y%m%d%H%M%S')" \
"${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \
|| die "${_status_msg}"

Expand Down
2 changes: 1 addition & 1 deletion engine/docker/bob-core/Dockerfile.template
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM ${BOB_CURRENT_STAGE3_ID}
LABEL maintainer ${MAINTAINER}
LABEL maintainer="${MAINTAINER}"

RUN set -x && \
echo 'GENTOO_MIRRORS="http://distfiles.gentoo.org/"' >> /etc/portage/make.conf && \
Expand Down
2 changes: 1 addition & 1 deletion engine/docker/bob-portage/Dockerfile.template
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM busybox:latest

LABEL maintainer ${MAINTAINER}
LABEL maintainer="${MAINTAINER}"

COPY ${BOB_CURRENT_PORTAGE_FILE} /

Expand Down
2 changes: 1 addition & 1 deletion template/docker/builder/Dockerfile.template
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ${NAMESPACE}/${_tmpl_image_name}
LABEL maintainer ${MAINTAINER}
LABEL maintainer="${MAINTAINER}"

CMD ["/bin/bash"]
2 changes: 1 addition & 1 deletion template/docker/image/Dockerfile.template
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM ${IMAGE_PARENT}
LABEL maintainer ${MAINTAINER}
LABEL maintainer="${MAINTAINER}"

ADD rootfs.tar /

Expand Down

0 comments on commit 39e0056

Please sign in to comment.