Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate uniqueness fixes and recurse into array elements, other improvements #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomreitz
Copy link
Collaborator

@tomreitz tomreitz commented Dec 4, 2024

This PR:

  • fixes a bug which made the uniqueness validation method always succeed (as the uniqueness hash list was emptied before processing each payload)
  • improves performance of the uniqueness validation method by moving certain preparatory steps (building the identity parameter structure, resolving the swagger reference definition, etc.) outside the payload processing loop (so it's only done once, not for every payload)
  • implements recursive uniqueness validation of array elements within payloads, as requested/discussed in this item
  • improves validation error messages to include the validation method that failed

@tomreitz tomreitz changed the title validate fixes and uniqueness in array elements validate uniqueness fixes and recurse into array elements, other improvements Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant