-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NWEA-Map: Add note about assessment ID #48
Conversation
Feature/CLI_TX-KEA
Feature/CMAS growth optional add-on
TX-KEA fix obj assess: namespace mismatch
Fixed CLI Circle Duplicate Records
I think this could move to around line 16-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing this!
related to #12 |
<details> | ||
<summary> Assessment ID </summary> | ||
|
||
The `assessmentIdentifier` used in this repo is "NWEA-Map." Some implementations may wish to spell or format this differently (e.g. "NWEA-MAP"). Double check your implementation and, if necessary, update the following files prior to running: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncmerfeld Does 'update the following files' mean using project composition? I think if so we should state that and maybe link to the PC part of the EM readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't think I understand project composition well enough to answer confidently, but I think no. All that's needed is to alter some string values in the listed files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what I was thinking is that if someone is just installing this bundle, they can't edit the files unless they created a branch of the bundles repo and kept their project on that branch. @susanxiong do you have thoughts here? Curious what Jeffco is doing for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah that's fair. So far I've only been using bundles from a developer's perspective so hadn't thought too much about what more of an "end user" would do. Hm…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oop, we don't have it set up to run automatically or anything, so to run MAP files, we have just been pulling down the repo locally and modifying the files as needed before running earthmover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we make assessment ID a runtime argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay gotcha! I think pushing people to use project composition in this situation is ideal since the goal of that feature is to allow people to make edits to the original bundle if something doesn't work for your particular implementation
1531f97
to
dc08917
Compare
Adds a maintenance note to the NWEA-Map bundle advising users to check the assessment ID used by their implementation.