-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/mvpa update #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/mvpa update #189
Conversation
|
Also I grabbed the template bundle from the feature/template_bundle_best_practice_updates branch. Hence some of your commits showing up here in the _template_bundle folder |
assessments/MVPA/README.md
Outdated
| @@ -0,0 +1,106 @@ | |||
| * **Title**: Template Bundle | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind updating this to match MVPA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't super clear on our readme best practices - a lot of what is in here is specific to the template bundle. Here's an example of a good readme file from a different bundle. We usually list out necessary files, params, and then include a sample command that points to the sample file from the bundle and should run for anyone who clones the repo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, got you. I'll update more comprehensively. Sorry about that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(actually, properly) updated now!
| @@ -0,0 +1,76 @@ | |||
| assessmentIdentifier,originalGrade,gradeLevelDescriptor | |||
| MVPA_alg1,,uri://ed-fi.org/GradeLevelDescriptor#Ninth grade | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the originalGrade column necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this column!
| }, | ||
| { | ||
| "assessmentReportingMethodDescriptor": "{{namespace}}/AssessmentReportingMethodDescriptor#Achievement Level Ext", | ||
| "performanceLevelDescriptor": "{{namespace}}/PerformanceLevelDescriptor#Multiple possible interpretations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the actual descriptor code value instead of the description!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! made this change in the most recent commit
| @@ -0,0 +1,16 @@ | |||
| codeValue,description,namespace,shortDescription | |||
| 5+,Multiple possible interpretations,uri://instructure.org/PerformanceLevelDescriptor,Multiple possible interpretations | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is instructure.org and elsewhere we have instructure.com - I think .com is correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, just fixed this. Thanks for catching!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the values you are filling in at the 'assessment reporting method descriptors' sections throughout this template are the longer versions of the score names like 'Percent Correct' - those are going to fail because they need to match the codeValues you set in the assessmentReportingMethodDescriptors.csv file, which appear to match the column names from the original file (which is correct): so the values here need to be swapped with those code values, which appear to look like 'PercCorr' instead of 'Percent Correct'. So for example, the first part of the first array here will look like this: [PercCorr, "PercCorr", "Decimal"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation -- I get this a lot more clearly now. This is updated.
One more question related to this template: right now whenAssessedGradeLevelDescriptor is sending an empty string, because we don't actually have any information about the student's enrolled grade within the file, which can become a problem with the high school MVPA assessments.
Is the best course of action to set whenAssessedGradeLevelDescriptor as "N/A", or something similar? Or is there a better way to handle that?
First pass at bundle for MVPA assessments. Key updates are: