Skip to content

Conversation

@gnguyen87
Copy link

This PR addresses this JIRA ticket.

@gnguyen87 gnguyen87 requested a review from jalvord1 August 21, 2025 20:56
- display_name: "Assessment data"
env_var: "INPUT_FILE"
is_required: true
file_type: ["csv", "txt"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true, or is the input file for this assessment always a CSV?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has always been the file_type options across bundles so i believe it is true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends on the input defined in earthmover.yaml. For example, STAAR_Interim only takes CSVs and from what I can tell the same is true here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this bundle will only accept a csv file!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated now!

@@ -0,0 +1,18 @@
display_name: "PSAT_SAT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jalvord1 I suppose we'll want a different display name here a la "PSAT/SAT" or something that looks a bit more human

student_ids:
git: https://github.com/edanalytics/earthmover_edfi_bundles.git
branch: main
branch: fix/empty_edfi_id_types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be merged, but we need it here until this PR is out.

schoolYear: ${API_YEAR}
assessmentIdentifier: "{%raw%}${TEST_TYPE}_{{map_year_to_version(administrationDate)}}{%endraw%}"
namespace: "uri://collegeboard.org"
assessmentCategoryDescriptor: "${DESCRIPTOR_NAMESPACE}/AssessmentCategoryDescriptor#College entrance exam"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jalvord1 is DESCRIPTOR_NAMESPACE something we need to account for? I see it still defaults to Ed-Fi

@johncmerfeld johncmerfeld force-pushed the feature/SC_descriptor_mapping branch from 5c22e30 to 4da714f Compare September 11, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants