-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/sc descriptor mapping #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
assessments/PSAT_SAT/_metadata.yaml
Outdated
| - display_name: "Assessment data" | ||
| env_var: "INPUT_FILE" | ||
| is_required: true | ||
| file_type: ["csv", "txt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true, or is the input file for this assessment always a CSV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has always been the file_type options across bundles so i believe it is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it depends on the input defined in earthmover.yaml. For example, STAAR_Interim only takes CSVs and from what I can tell the same is true here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this bundle will only accept a csv file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated now!
| @@ -0,0 +1,18 @@ | |||
| display_name: "PSAT_SAT" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jalvord1 I suppose we'll want a different display name here a la "PSAT/SAT" or something that looks a bit more human
| student_ids: | ||
| git: https://github.com/edanalytics/earthmover_edfi_bundles.git | ||
| branch: main | ||
| branch: fix/empty_edfi_id_types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should not be merged, but we need it here until this PR is out.
| schoolYear: ${API_YEAR} | ||
| assessmentIdentifier: "{%raw%}${TEST_TYPE}_{{map_year_to_version(administrationDate)}}{%endraw%}" | ||
| namespace: "uri://collegeboard.org" | ||
| assessmentCategoryDescriptor: "${DESCRIPTOR_NAMESPACE}/AssessmentCategoryDescriptor#College entrance exam" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jalvord1 is DESCRIPTOR_NAMESPACE something we need to account for? I see it still defaults to Ed-Fi
5c22e30 to
4da714f
Compare
This PR addresses this JIRA ticket.