-
Notifications
You must be signed in to change notification settings - Fork 7
Dominie Assessment #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dominie Assessment #167
Conversation
assessments/Dominie/earthmover.yaml
Outdated
| - operation: filter_rows | ||
| query: "result != 'NULL' and result!=''" | ||
| behavior: include | ||
| - operation: distinct_rows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of the distinct rows here? Are there dupes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jalvord1 Yes, we found duplicates. For example, for 2015-2016 file, after the distinct_rows in studentAssessment, the duplicated values were reduced from 140 to 104.
This means 2 things:
- There are records with exactly the same information in all cells
- There are 104 students with records that have the same information but different scores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah since this distinct rows will just drop exact dupe rows, I'm cool with it
|
This looks good @msuarezcrocus - just want to check on a few things:
|
Wendy agreed with you. |
Ha, thank you for reminding me that I already weighed in on this 😶🌫️ Too many assessments flying around in my brain. |
|
No problem at all! |
| Dominie_General_Letter Know,Dominie Letter Know Assessment,uri://pearson.com/Assessments/Dominie,Dominie,uri://pearson.com/Assessments/Dominie/AssessmentCategoryDescriptor#Diagnostic,uri://ed-fi.org/academicSubjectDescriptor#Early Literacy,letterknow | ||
| Dominie_General_Phoneme Segmentation,Dominie Phoneme Segmentation Assessment,uri://pearson.com/Assessments/Dominie,Dominie,uri://pearson.com/Assessments/Dominie/AssessmentCategoryDescriptor#Diagnostic,uri://ed-fi.org/academicSubjectDescriptor#Early Literacy,phonseg | ||
| Dominie_General_Phoneme Deletion,Dominie Phoneme Deletion Assessment,uri://pearson.com/Assessments/Dominie,Dominie,uri://pearson.com/Assessments/Dominie/AssessmentCategoryDescriptor#Diagnostic,uri://ed-fi.org/academicSubjectDescriptor#Early Literacy,phondel | ||
| Dominie_General_Core Rdg.,Dominie Core Rdg. Assessment,uri://pearson.com/Assessments/Dominie,Dominie,uri://pearson.com/Assessments/Dominie/AssessmentCategoryDescriptor#Diagnostic,uri://ed-fi.org/academicSubjectDescriptor#Early Literacy,corerdg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the assessment IDs to be more consistent in using underscores, removing periods and other special characters?
|
@jalvord1, please let me know if these IDs are acceptable or if you’d prefer adjustments. |


Hi @jalvord1! This bundle is ready for your review.