-
Notifications
You must be signed in to change notification settings - Fork 7
This is the PreACT pull request #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
assessments/PreACT/data/metadata.csv
Outdated
| @@ -0,0 +1,1566 @@ | |||
| FieldName,Short Description,Full Description,Target Valid Values,start_index,end_index,field_length,Legacy Valid Values | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between this and the colspecs file? Might not need this directly in the bundle itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference is that this file has the column definition and its possible values; It isn't really needed in the bundle so i just removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this successfully deleted
| @@ -0,0 +1,2 @@ | |||
| assessmentIdentifier,assessmentTitle,namespace,assessmentCategoryDescriptor,academicSubjectDescriptor | |||
| PreACT,PreACT Composite,uri://act.org,uri://ed-fi.org/AssessmentCategoryDescriptor#Benchmark test,uri://ed-fi.org/AcademicSubjectDescriptor#Composite | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the assessment title should also just be PreACT, instead of PreACT Composite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed.
| @@ -0,0 +1,24 @@ | |||
| identificationCode,assessmentIdentifier,description,namespace,parentIdentificationCode,academicSubjectDescriptor | |||
| PreACT_COMP,PreACT,Composite Score,uri://act.og/Assessment,,uri://ed-fi.org/AcademicSubjectDescriptor#Composite | |||
| PreACT_Eng,PreACT,English Scale Score,uri://act.og/Assessment,PreACT_COMP,uri://ed-fi.org/AcademicSubjectDescriptor#English | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would remove the score name from the description - some have 'Scale Score' and some have 'Raw Score', that will be captured within the scores, but its not the description of the objective assessment itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed.
| "assessmentReportingMethodDescriptor": "uri://act.org/Assessment/AssessmentReportingMethodDescriptor#Progress Toward Career Readiness Indicator", | ||
| "maximumScore": "0", | ||
| "minimumScore": "0", | ||
| "performanceLevelDescriptor": "uri://act.org/Assessment//PerformanceLevelDescriptor#Unlikely to obtain an NCRC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting these will have to change to the raw value as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be earthmover.yaml not earthmover.yml
assessments/PreACT/earthmover.yaml
Outdated
| - operation: duplicate_columns | ||
| columns: | ||
| Test_Dte: administrationDate | ||
| Stu_ID_Num: studentUniqueId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be parameterized or else the student ID xwalking feature will not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now resolved.
assessments/PreACT/data/metadata.csv
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
No description provided.